Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strain #328

Merged
merged 23 commits into from
Sep 3, 2021
Merged

Strain #328

merged 23 commits into from
Sep 3, 2021

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented Aug 25, 2021

Calculation of local strain.

Example:

from pyiron_atomistics import Project
pr = Project('.')
bulk = pr.create.structure.bulk('Fe', cubic=True)
structure = bulk.apply_strain(np.random.random((3,3))*0.1, return_box=True)
print(structure.analyse.get_strain(bulk))

@samwaseda samwaseda marked this pull request as draft August 25, 2021 16:51
@coveralls
Copy link

coveralls commented Aug 25, 2021

Pull Request Test Coverage Report for Build 1197250093

  • 103 of 106 (97.17%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 68.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/strain.py 100 103 97.09%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/structure/has_structure.py 5 85.0%
pyiron_atomistics/atomistics/job/structurecontainer.py 6 77.22%
Totals Coverage Status
Change from base Build 1163488168: 0.3%
Covered Lines: 11085
Relevant Lines: 16231

💛 - Coveralls

@samwaseda samwaseda marked this pull request as ready for review August 25, 2021 17:17
@samwaseda samwaseda requested review from liamhuber, pmrv and niklassiemer and removed request for liamhuber and pmrv August 25, 2021 17:17
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strains class has unit tests outstanding.

Otherwise a few nits, but the functionality seems great and I have no complaints about the overall architecture. As soon as the unit tests are there (and it's PEP8 linted!!!) I'm happy.

pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
tests/atomistics/structure/test_analyse.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
samwaseda and others added 3 commits August 30, 2021 07:50
Co-authored-by: Liam Huber <liam.huber@gmail.com>
Co-authored-by: Liam Huber <liam.huber@gmail.com>
@samwaseda
Copy link
Member Author

So now I finally installed a PEP8 plugin (which I'll hopefully regularly use from now on) so it should be fine :)

Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some formatting suggestions to play nice with sphinx, but looks good otherwise!

pyiron_atomistics/atomistics/structure/analyse.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/analyse.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
pyiron_atomistics/atomistics/structure/strain.py Outdated Show resolved Hide resolved
@samwaseda samwaseda merged commit 61fc2a2 into master Sep 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the strain branch September 3, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants