Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change pointer to copy #350

Merged
merged 1 commit into from
Sep 8, 2021
Merged

change pointer to copy #350

merged 1 commit into from
Sep 8, 2021

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented Sep 8, 2021 •
edited
Loading

Closes #341

@samwaseda
Copy link
Member Author

Since this has been discussed in #341, I'm going to merge it as soon as the tests pass

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1212169083

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.293%
Totals Coverage Status
Change from base Build 1206162647: 0.0%
Covered Lines: 11084
Relevant Lines: 16230
💛 - Coveralls

@samwaseda samwaseda merged commit 190eeec into master Sep 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the get_chemical_symbols branch September 8, 2021 06:35
@sudarsan-surendralal sudarsan-surendralal mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Atoms.get_chemical_indices() return pointer?
2 participants
@samwaseda @coveralls