-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use state instead of Settings #424
Conversation
A surprising amount of the time that just meant getting rid of the Settings import, as it was unused. I also snuck in a couple other unused import removals and some encoding info additions here and there, depending on the repo.
You are a bit early, since the |
😆 yep, we're looking at it simultaneously |
Pull Request Test Coverage Report for Build 1516971076
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not particularly happy with the fact that there's no test, but other than that it looks good to me. :)
We'll, the basic state stuff is tested over in base. It's true though that I didn't add any special tests, and Marvin did indeed track down a state related (but maybe not state or caused?) issue. I don't know how to conveniently link issues on my phone in the app though, so you'll just have to go look for it 🤣 |
A surprising amount of the time that just meant getting rid of the Settings import, as it was unused. I also snuck in a couple other unused import removals and some encoding info additions here and there, depending on the repo.