Use super in get_structure

[pmrv]

Use super instead of hardcoding GenericInteractive. I just want to run the tests on this.

[coveralls]

Pull Request Test Coverage Report for Build 656936926

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 64.876%

---

Totals
Change from base Build 642350783:	0.0%
Covered Lines:	10735
Relevant Lines:	16547

---

💛 - Coveralls

[pmrv]

The codacy nag comes from them not considering multiple inheritance issues. Since we want to bypass the get_structure() from LammpsBase and AtomisticGenericJob and instead want the one from GenericInteractive, this is the correct way to call super().

[niklassiemer]

Then, of course, one may ask if our hierarchy is correctly set up since we have to use the method defined multiple layers above...

[pmrv]

In the case of multiple inheritance like we have it (see below) it's necessary, since python's default mro is depth-first, but we want breadth first here.

AtomisticGeneric
       |
LammpsBase    GenericInteracive
       |                 |
       \                 /
       LammpsInteractive 

That said, since all our lammps jobs are actually LammpsInteractive under the hood, restructuring would be possible.

[jan-janssen]

I just looked at the pull request now, from my perspective it is a bit more complex:

            GenericJob
            /         \
            |         |
AtomisticGeneric      |
            |      GenericInteracive
     LammpsBase       |   
            |         |
            \        /
       LammpsInteractive 

A possible way to resolve this would be:

 GenericJob
      |
GenericInteracive
      | 
AtomisticGeneric
      | 
LammpsBase
      | 
LammpsInteractive 

This makes a lot of sense when the static jobs also support interactive execution, meaning calculating energies and forces for multiple structures, which should definitely be a goal.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[pmrv]

Since it's unlikely that we restructure soon and everything seems to work, I'll merge this as soon as the notebook tests pass.