-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add elastic tensor rotations and thermodynamic parameters #5
Conversation
Pull Request Test Coverage Report for Build 497870622
💛 - Coveralls |
@samwaseda What about this pull request? I mainly just copied it from the previous pyiron repository. |
Sorry I'm gonna finish the changes this week. |
I guess I should be doing more about this class (especially concerning the elastic constants), but since I'm not the expert in this area, I leave it like this for now. If there's someone who wants to work on it, they can extend the class to make orientation-dependent functionality more flexible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@liamhuber and @samwaseda if both of you agree I would merge this now |
I was faster! 😎 |
Move pull request pyiron/pyiron#1203