Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elastic tensor rotations and thermodynamic parameters #5

Merged
merged 6 commits into from
Feb 3, 2021

Conversation

jan-janssen
Copy link
Member

Move pull request pyiron/pyiron#1203

@coveralls
Copy link

coveralls commented Jan 10, 2021

Pull Request Test Coverage Report for Build 497870622

  • 25 of 27 (92.59%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 64.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/master/elastic.py 25 27 92.59%
Totals Coverage Status
Change from base Build 495736873: 0.05%
Covered Lines: 10561
Relevant Lines: 16330

💛 - Coveralls

@jan-janssen
Copy link
Member Author

@samwaseda What about this pull request? I mainly just copied it from the previous pyiron repository.

@samwaseda
Copy link
Member

Sorry I'm gonna finish the changes this week.

@samwaseda
Copy link
Member

I guess I should be doing more about this class (especially concerning the elastic constants), but since I'm not the expert in this area, I leave it like this for now. If there's someone who wants to work on it, they can extend the class to make orientation-dependent functionality more flexible.

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing

@stale
Copy link

stale bot commented Feb 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Feb 3, 2021
@jan-janssen
Copy link
Member Author

@liamhuber and @samwaseda if both of you agree I would merge this now

@samwaseda samwaseda merged commit ab422ed into master Feb 3, 2021
@samwaseda samwaseda deleted the elastic branch February 3, 2021 12:57
@samwaseda
Copy link
Member

I was faster! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants