Spx refactor #505
Merged
Spx refactor #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1749937339
💛 - Coveralls |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@niklassiemer Black is failing. Is there a possibility to enforce the conversion? |
|
ah nice thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly refactored the SPHInX output. There's however one important change: the output is now
DataContainer. I think this allows the user to see a more insightful output data whenjob['output/generic']is called. Older SPHInX calculations can still be loaded (and will also work like before), but you can also update the output viajob.update_sphinx(). And if the job is meant to be kept for a long time, the update should be effectuated at some point, because probably at some point we (or rather I) will drop the conventional hdf format support.