-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include DataConatiner check #514
Conversation
Pull Request Test Coverage Report for Build 1768084316
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit to use a proper instance check, otherwise lgtm.
content = ( | ||
"main { ricQN { ric { maxDist = %f; withAngles; } maxSteps = %i; dEnergy = %f; dF = %f; maxStepLength = %f; softModeDamping = %f;}}" | ||
% ( | ||
maxDist, | ||
ionic_steps, | ||
ionic_energy_tolerance, | ||
ionic_force_tolerance, | ||
max_step_length, | ||
soft_mode_damping, | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not part of the change set, but this should really be constructed programmatically
content = Group({'main': {'ricQN': {'ric': {...}, 'maxSteps': ionic_steps, ...}})
Co-authored-by: Marvin Poul <poul@mpie.de>
No description provided.