Improve Murngahan #531
Merged
Improve Murngahan #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1848469346
💛 - Coveralls |
|
We can now input an axis and add plot kwargs arguments to the plot function. I hope this doesn't break anything @jan-janssen |
sudarsan-surendralal
added
the
format_black
| @@ -90,7 +90,12 @@ def test_fitting_routines(self): | |||
| murn._hdf5["output/equilibrium_volume"] = 448.4033384110422 | |||
| murn.status.finished = True | |||
|
|
|||
| murn.plot(plt_show=False) | |||
| self.assertIsInstance(murn.plot(plt_show=False), matplotlib.axes.Axes) | |||
There was a problem hiding this comment.
Note: Apparently calling plt.show() in our CI environment causes the Windows and MacOS tests to run forever (Linux tests seem to be fine).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cosmetic changes to module