Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace triu by triu_indices #539

Merged
merged 5 commits into from Mar 28, 2022
Merged

replace triu by triu_indices #539

merged 5 commits into from Mar 28, 2022

Conversation

samwaseda
Copy link
Member

Closes #246

@coveralls
Copy link

coveralls commented Feb 15, 2022

Pull Request Test Coverage Report for Build 1884463820

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 203 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.227%

Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/master/murnaghan.py 14 72.98%
pyiron_atomistics/lammps/control.py 28 89.05%
pyiron_atomistics/vasp/base.py 50 65.29%
pyiron_atomistics/sphinx/base.py 111 81.82%
Totals Coverage Status
Change from base Build 1841593007: 0.03%
Covered Lines: 11685
Relevant Lines: 16639

💛 - Coveralls

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Feb 22, 2022
@pmrv
Copy link
Contributor

pmrv commented Mar 8, 2022

As discussed in #246 I've tried all combinations of running the job for an HCP cell. Results are below first as matrices then as bar plots.

Generally orthorhombic structures seem to work best, but notice in the bar plot the inconsistency between c31 and c32 w/ pressure and c44 and c55 w/o pressure, which are supposed to be equal in HCP.

cij_bar
cij_matshow

@samwaseda
Copy link
Member Author

As discussed in #246 I've tried all combinations of running the job for an HCP cell. Results are below first as matrices then as bar plots.

Generally orthorhombic structures seem to work best, but notice in the bar plot the inconsistency between c31 and c32 w/ pressure and c44 and c55 w/o pressure, which are supposed to be equal in HCP.

For primitive I have frankly no idea why it's not working. Otherwise is it possible that the lattice parameter is not relaxed beforehand?

@pmrv
Copy link
Contributor

pmrv commented Mar 10, 2022

As discussed in #246 I've tried all combinations of running the job for an HCP cell. Results are below first as matrices then as bar plots.
Generally orthorhombic structures seem to work best, but notice in the bar plot the inconsistency between c31 and c32 w/ pressure and c44 and c55 w/o pressure, which are supposed to be equal in HCP.

For primitive I have frankly no idea why it's not working. Otherwise is it possible that the lattice parameter is not relaxed beforehand?

I relaxed all the structures with calc_minimize(pressure=[0]*6, ionic_force_tolerance=1e-6) beforehand.

@samwaseda
Copy link
Member Author

I relaxed all the structures with calc_minimize(pressure=[0]*6, ionic_force_tolerance=1e-6) beforehand.

hm ok then I'm going to include a symmetrisation step

@samwaseda
Copy link
Member Author

I realised that it's related to the fact that the point group symmetries that spglib do not help us symmetrize those values, so that for now it can be only avoided by increasing the number of points. In theory I guess it's possible to solve this problem by reducing the structure to the smallest unit and get all the symmetries there, but I'm not really sure how to do it properly. One way or other, this is more a fundamental problem, which is not directly related to this PR, so I'd suggest to merge this one and open another one as soon as we find a solution.

@stale
Copy link

stale bot commented Mar 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 26, 2022
@stale stale bot removed the stale label Mar 28, 2022
@samwaseda samwaseda merged commit 584a143 into master Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the elast_bugfix branch March 28, 2022 07:01
@pmrv
Copy link
Contributor

pmrv commented Mar 28, 2022

I realised that it's related to the fact that the point group symmetries that spglib do not help us symmetrize those values, so that for now it can be only avoided by increasing the number of points. In theory I guess it's possible to solve this problem by reducing the structure to the smallest unit and get all the symmetries there, but I'm not really sure how to do it properly. One way or other, this is more a fundamental problem, which is not directly related to this PR, so I'd suggest to merge this one and open another one as soon as we find a solution.

I think both spglib and pymatgen have methods to get reduced unit cells from super cells, but I haven't looked into how they work. If increasing the number of points works, should we just bump the default value for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElasticTensor bug when use_pressure=False
6 participants