New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace triu by triu_indices #539
Conversation
Pull Request Test Coverage Report for Build 1884463820
💛 - Coveralls |
As discussed in #246 I've tried all combinations of running the job for an HCP cell. Results are below first as matrices then as bar plots. Generally orthorhombic structures seem to work best, but notice in the bar plot the inconsistency between c31 and c32 w/ pressure and c44 and c55 w/o pressure, which are supposed to be equal in HCP. |
For primitive I have frankly no idea why it's not working. Otherwise is it possible that the lattice parameter is not relaxed beforehand? |
I relaxed all the structures with |
hm ok then I'm going to include a symmetrisation step |
I realised that it's related to the fact that the point group symmetries that spglib do not help us symmetrize those values, so that for now it can be only avoided by increasing the number of points. In theory I guess it's possible to solve this problem by reducing the structure to the smallest unit and get all the symmetries there, but I'm not really sure how to do it properly. One way or other, this is more a fundamental problem, which is not directly related to this PR, so I'd suggest to merge this one and open another one as soon as we find a solution. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think both spglib and pymatgen have methods to get reduced unit cells from super cells, but I haven't looked into how they work. If increasing the number of points works, should we just bump the default value for that? |
Closes #246