Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vasp Outcar: elegant split of electronic and ionic steps #556

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Vasp Outcar: elegant split of electronic and ionic steps #556

merged 1 commit into from
Mar 8, 2022

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen mentioned this pull request Mar 6, 2022
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1940309474

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 70.464%
Totals Coverage Status
Change from base Build 1922775632: -0.01%
Covered Lines: 11850
Relevant Lines: 16817
💛 - Coveralls

sudarsan-surendralal
sudarsan-surendralal approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In general, there is scope for improving these parsers (making them more elegant/faster)

@jan-janssen jan-janssen merged commit 907991b into master Mar 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the vasp_ionic_electronic branch March 8, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudarsan-surendralal sudarsan-surendralal sudarsan-surendralal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jan-janssen @coveralls @sudarsan-surendralal