Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to normalize E/V curves by atoms + docstrings #638

Merged
merged 3 commits into from May 31, 2022
Merged

Add a flag to normalize E/V curves by atoms + docstrings #638

merged 3 commits into from May 31, 2022

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented May 30, 2022

No description provided.

@pmrv pmrv added documentation Improvements or additions to documentation enhancement New feature or request labels May 30, 2022
@jan-janssen
Copy link
Member

@pmrv - Please use the master branch as reference, as I had to revert a couple of pull requests which broke the notebook tests:

@pmrv
Copy link
Contributor Author

pmrv commented May 30, 2022

For anyone else has to clean up their pull requests:

git checkout master
git pull
git rebase master <YOUR_BRANCH_NAME>  --onto origin/master

(assuming to branched off your local master before the big revert happened).

@coveralls
Copy link

coveralls commented May 30, 2022 •
edited

Pull Request Test Coverage Report for Build 2411126600

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 69.115%
Totals Coverage Status
Change from base Build 2332655534: 0.01%
Covered Lines: 11679
Relevant Lines: 16898
💛 - Coveralls

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label May 30, 2022
jan-janssen
jan-janssen approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen mentioned this pull request May 30, 2022
Closed
@pmrv pmrv merged commit 184af2d into master May 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the murn_peratom branch May 31, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request format_black reformat the code using the black standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmrv @jan-janssen @coveralls @pyiron-runner