New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix SPHInX restarts #644
fix SPHInX restarts #644
Conversation
restarts from waves or density must rewrite initialGuess group
Pull Request Test Coverage Report for Build 2460516400
💛 - Coveralls |
I am lost with how debug the failed notebook, because it seems the SPHInX job has not run properly. Is there any way of running the failing notebook interactively using this version of pyiron (i.e. from the current branch), to see what might have happened? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to find a problem but it looks good to me. The only one thing is that def restart
is now somewhat a bit lengthy (for the python standard). At some point we should probably think about reorganising it.
OK, I am done with fixing. For the test coverage decrease, not sure if this is a problem. I personally don't think it makes sense to implement unit testing for the restart, as this would require a successfully completed sphinx job (incl. density + waves sxb files). |
Since some people need it (i.e. me) I merged it |
restarts from waves or density must rewrite initialGuess group