Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SPHInX restarts #644

Merged
merged 10 commits into from Jun 10, 2022
Merged

fix SPHInX restarts #644

merged 10 commits into from Jun 10, 2022

Conversation

freyso
Copy link
Contributor

@freyso freyso commented Jun 3, 2022

restarts from waves or density must rewrite initialGuess group

restarts from waves or density must rewrite initialGuess group
@coveralls
Copy link

coveralls commented Jun 3, 2022

Pull Request Test Coverage Report for Build 2460516400

  • 16 of 28 (57.14%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 69.108%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/sphinx/base.py 16 28 57.14%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/sphinx/base.py 2 82.31%
Totals Coverage Status
Change from base Build 2413518148: -0.006%
Covered Lines: 11689
Relevant Lines: 16914

💛 - Coveralls

@freyso
Copy link
Contributor Author

freyso commented Jun 3, 2022

I am lost with how debug the failed notebook, because it seems the SPHInX job has not run properly. Is there any way of running the failing notebook interactively using this version of pyiron (i.e. from the current branch), to see what might have happened?

@jan-janssen
Copy link
Member

I am lost with how debug the failed notebook, because it seems the SPHInX job has not run properly. Is there any way of running the failing notebook interactively using this version of pyiron (i.e. from the current branch), to see what might have happened?

You can run any branch on mybinder (alternatively to testing locally):
Binder

[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/pyiron/pyiron_atomistics/fix_restart_sphinx)

Copy link
Contributor

@skatnagallu skatnagallu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find a problem but it looks good to me. The only one thing is that def restart is now somewhat a bit lengthy (for the python standard). At some point we should probably think about reorganising it.

@freyso
Copy link
Contributor Author

freyso commented Jun 8, 2022

OK, I am done with fixing. For the test coverage decrease, not sure if this is a problem. I personally don't think it makes sense to implement unit testing for the restart, as this would require a successfully completed sphinx job (incl. density + waves sxb files).
@jan-janssen - any thoughts/concerns about this?
From my side, this can be merged.

@samwaseda samwaseda merged commit 43d7d4c into master Jun 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_restart_sphinx branch June 10, 2022 12:31
@samwaseda
Copy link
Member

Since some people need it (i.e. me) I merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants