Add numpy equality check for unit tests #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklassiemer
approved these changes
Jun 15, 2023
| @@ -13,6 +13,7 @@ | |||
| class TestProjectData(PyironTestCase): | |||
| @classmethod | |||
| def setUpClass(cls): | |||
| super().setUpClass() | |||
There was a problem hiding this comment.
I am happy to include this here, however, this would is not required for the functionality, is it?
There was a problem hiding this comment.
Yeah, that was just because I was at it already anyway.
niklassiemer
added
integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this one can do
self.assertEqual()on arrays directly. Downside side that really both values have to be arrays, so I had to add some conversions.Because this relies on
setUpI had to add a bunch ofsupercalls.