GenericJob: extend the compress() function #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For codes like VASP we typically remove certain files before we compress the working directory and other files we leave out of the archive. This is now possible using `job.files_to_compress` and `job.files_to_remove`. Both properties return a list, so the user can append additional files.
pmrv
approved these changes
Apr 15, 2024
pyiron_base/jobs/job/util.py
Outdated
| @@ -295,11 +303,9 @@ def _job_compress(job, files_to_compress=None): | |||
| tar.add(name) | |||
| for name in files_to_compress: | |||
| if "tar" not in name: | |||
There was a problem hiding this comment.
Not introduced here, but would be nice to change if "tar" not in name: to name != _job_compressed_name(job). Otherwise lgtm.
There was a problem hiding this comment.
Thanks - I updated the pull request
jan-janssen
commented
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For codes like VASP we typically remove certain files before we compress the working directory and other files we leave out of the archive. This is now possible using
job.files_to_compressandjob.files_to_remove. Both properties return a list, so the user can append additional files.