Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the pack() and unpack() method #1401

Merged
merged 11 commits into from
May 23, 2024
Merged

Fixes for the pack() and unpack() method #1401

merged 11 commits into from
May 23, 2024

Conversation

jan-janssen
Copy link
Member

@jyang2009 based on our discussion I created a couple of fixes for the pack() and unpack() method. Can you check if these resolve the issues you had with archiving on ptmp?

@jan-janssen jan-janssen linked an issue Mar 28, 2024 that may be closed by this pull request
@jyang2009
Copy link

Hi Jan,

I've tested this fix but got a new error when using the copy_to function. I copy the error below.
Screen Shot 2024-04-05 at 1 45 41 PM

Best,
Jing

@jan-janssen
Copy link
Member Author

@jyang2009 Can you provide a bit more details about the commands you were executing that resulted in this error?

@jan-janssen jan-janssen marked this pull request as draft April 6, 2024 16:40
@jyang2009
Copy link

Hi Jan,

I just used the code that I used to copy jobs to the new project, which was working previously.
pr_archive = Project("archive")
job_new = job.copy_to(project=pr_archive)

@jan-janssen
Copy link
Member Author

Hi Jan,

I've tested this fix but got a new error when using the copy_to function. I copy the error below.

Best, Jing

Hi Jing,

I am sorry for the delay. The error message basically says, that pr_archive is not a recognised data type. You can check the data type using:

type(pr_archive)

My assumption would be it is just a str or a Path object. In those cases you can create a project from it using:

pr_archive=Project(pr_archive)

This should resolve this issue.

Best,

Jan

@jan-janssen jan-janssen mentioned this pull request May 23, 2024
12 tasks
@jan-janssen jan-janssen marked this pull request as ready for review May 23, 2024 12:00
@jan-janssen
Copy link
Member Author

@samwaseda Originally I was waiting for feedback from @jyang2009 if this solves her problem, as from my side this looks ready to be merged.

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have probably changed the error message and kept the current functionality, but I'm ok with the suggested solution.

@samwaseda
Copy link
Member

Side note: I don't think the csv file should be separated from the tar file, so I will probably remove it entirely in this PR

@jan-janssen jan-janssen merged commit 78b4289 into main May 23, 2024
25 checks passed
@jan-janssen jan-janssen deleted the pack_fixes branch May 23, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in project packing
3 participants