Unlock when calling from_hdf for DataContainer #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrv
force-pushed
the
unlock_datacontainer
branch
from
9104139
to
9851ad5
Compare
pmrv
force-pushed
the
unlock_datacontainer
branch
from
c527329
to
79e4f14
Compare
|
The unittest failure was because the original commit also removed some code that triggered the warning the test was locking for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reloading a
DataContainerobject threw a warning that the object was locked whenself.clear()was called infrom_hdf.Change 1: Run
from_hdfwhile unlocked.Change 2: Remove additional warning that the object is being unlocked.