Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] replace logger with snippets version #1465

Merged
merged 10 commits into from
Jun 3, 2024

Conversation

liamhuber
Copy link
Member

i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.

liamhuber and others added 3 commits June 3, 2024 10:11
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.
@liamhuber
Copy link
Member Author

The linter got rid of my redirect. I am going to get rid of it in the next PR anyhow, but I just want to point out that the robot is obliviously wrecking my software engineering choices. Sometimes an unused import is intentional.

Screen Shot 2024-06-03 at 10 26 07

@liamhuber
Copy link
Member Author

FFS, is there a flag to stop the damned bot?

@liamhuber
Copy link
Member Author

Ok, I tried bypassing the linter by adding --no-verify on my local machine before pushing the commit, but this doesn't work. I don't see how to bypass the linter when it's operating on the remote machine, so I'm just going to give in and "trick" it. 👎 👎

@jan-janssen
Copy link
Member

i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.

I thought we agreed to completely remove the classes replaced by pyiron_snippets.

[minor] remove the backwards compatibility redirects
@jan-janssen jan-janssen merged commit 84b5de5 into snippets_deprecate Jun 3, 2024
14 checks passed
@jan-janssen jan-janssen deleted the snippets_logger branch June 3, 2024 18:34
@liamhuber
Copy link
Member Author

i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.

I thought we agreed to completely remove the classes replaced by pyiron_snippets.

Yes, but instead of having three compatibility breaking commits, I opted to go for three backwards-compatible patches and then a single PR to remove all the compatibility shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants