Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the h5io interface #1470

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Update the h5io interface #1470

merged 8 commits into from
Jun 7, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 6, 2024

By updating to h5io_browser=0.14 the custom read_dict_from_hdf() function can be replaced by the read_nested_dict_from_hdf() from h5io_browser.

@jan-janssen jan-janssen marked this pull request as draft June 6, 2024 20:08
@jan-janssen jan-janssen closed this Jun 7, 2024
@jan-janssen jan-janssen reopened this Jun 7, 2024
@jan-janssen jan-janssen marked this pull request as ready for review June 7, 2024 03:51
@jan-janssen jan-janssen requested a review from pmrv June 7, 2024 03:57
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jan-janssen jan-janssen merged commit 7de5ce9 into main Jun 7, 2024
45 of 46 checks passed
@jan-janssen jan-janssen deleted the h5io_update branch June 7, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants