New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unittesting template with filled projects #476
Conversation
Abstract class with a project with jobs and sub-projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree! Nice idea!
Some streamlining changes suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the streamlining of ToyJob
and the FilledProject
test case! With Liams suggestions this lgtm.
Co-authored-by: Liam Huber <liam.huber@gmail.com>
Co-authored-by: Liam Huber <liam.huber@gmail.com>
Co-authored-by: Liam Huber <liam.huber@gmail.com>
Co-authored-by: Liam Huber <liam.huber@gmail.com>
Co-authored-by: Liam Huber <liam.huber@gmail.com>
@liamhuber thanks for the suggestions. I've streamlined the |
I think it is useful in many cases (Edit: For example #476) to have test case templates with a
cls.project
class attribute which already has a few jobs and sub projects. Here's a minimal implementation.