Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to get padded and ragged arrays to FlattenedStorage #481

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Oct 21, 2021

I want this for pyiron/pyiron_atomistics#387 and I guess it could also be useful the get neighbors class.

@pmrv pmrv added the enhancement New feature or request label Oct 21, 2021
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few small typing/code style suggestions.

pyiron_base/generic/flattenedstorage.py Outdated Show resolved Hide resolved
pyiron_base/generic/flattenedstorage.py Outdated Show resolved Hide resolved
pyiron_base/generic/flattenedstorage.py Outdated Show resolved Hide resolved
pmrv and others added 2 commits October 22, 2021 09:33
Co-authored-by: Sudarsan Surendralal <surendralal@mpie.de>
Every array now has a default fill value associated
@pmrv pmrv merged commit 28c60c8 into master Oct 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the flatt_options branch October 26, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants