Extending tests to run one unittest suite for the oldest supported python #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly, due to some of our dependencies dropping older python versions support, I cannot install the same packages under python3.6. For now, I test at least python3.7, however, I would like to think about how to check our own compatibility to python3.6 (or drop the support). |
|
For python3.7 we have the ability to build the same environment and it is correctly failing now, thus, I merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #547 we need to fix broken python3.6 support. We have to do this since we were only alerted on the unittests of other repositories running older python version:
Thus, I now add one unit test run with python3.6 on a linux machine to check for this type of errors.