Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up config when database is disabled #578

Merged
merged 5 commits into from Dec 13, 2021
Merged

Clean up config when database is disabled #578

merged 5 commits into from Dec 13, 2021

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen linked an issue Dec 9, 2021 that may be closed by this pull request
Config is confusing #577
Open
@liamhuber liamhuber mentioned this pull request Dec 9, 2021
Open
liamhuber
liamhuber requested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only request is tests, which should be easy to implement by passing the necessary dict to state.update(), and then just calling a naked update in the tear down.

@jan-janssen
Copy link
Member Author

@liamhuber I added the corresponding tests

liamhuber
liamhuber approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The refactor made tests even easier, I like it

@jan-janssen jan-janssen merged commit eef00c2 into master Dec 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the fixconfig branch December 13, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamhuber liamhuber liamhuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config is confusing
2 participants
@jan-janssen @liamhuber