Fix compat tests #584
Merged
Fix compat tests #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-janssen
added
the
integration
Comment on lines
29
to
30
| grep -v "pyiron_base" ../pyiron_atomistics/.ci_support/environment.yml > environment.yml | ||
| tail -n +4 .ci_support/environment.yml >> environment.yml |
There was a problem hiding this comment.
What happens if we update a dependency in base but not (yet) in atomistics? would this work or throw an error due to twice the same dependency with different versions?
There was a problem hiding this comment.
To my understanding the last entry for the same package overwrites all previous ones
There was a problem hiding this comment.
It does not work ... here is an example
There was a problem hiding this comment.
I wrote a small python script to merge the environments https://github.com/pyiron/pyiron_base/blob/compatfix/.ci_support/condamerge.py
niklassiemer
approved these changes
Dec 14, 2021
| @@ -284,12 +284,12 @@ def _validate_viewer_configuration(config: Dict) -> None: | |||
| @staticmethod | |||
| def _validate_no_database_configuration(config: Dict) -> None: | |||
| if "disable_database" in config.keys() and config["disable_database"]: | |||
| if config["project_check_enabled"]: | |||
| if "project_check_enabled" in config.keys() and config["project_check_enabled"]: | |||
There was a problem hiding this comment.
I am a bit surprised to see this in this PR, but the changes are ok to me. Did they pop up here or just sneak in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.