Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert boolean config keys #629

Merged
merged 3 commits into from Jan 15, 2022
Merged

Convert boolean config keys #629

merged 3 commits into from Jan 15, 2022

Conversation

jan-janssen
Copy link
Member

No description provided.

liamhuber
liamhuber reviewed Jan 15, 2022
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of code duplication. Could we just extract it to a private routine with the same name as the pr?

@jan-janssen jan-janssen merged commit 1b25f46 into master Jan 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the config_fix branch January 15, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamhuber liamhuber liamhuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-janssen @liamhuber