Add local maintenance with defragment_storage #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| recursive=recursive, progress=progress, convert_to_object=False, **kwargs | ||
| ): | ||
| hdf = job.project_hdf5 | ||
| hdf.rewrite_hdf(job.name) |
There was a problem hiding this comment.
Would it be a good idea to remove the job_name argument for rewrite_hdf in this PR itself?
There was a problem hiding this comment.
I am not really sure. Looking at rewrite_hdf I sort of had the feeling that this only rewrites the job itself and not (necessarily) the overall file. I wanted to do (and probably include some tests into base) to see if it actually correctly rewrites the whole hdf file if multiple jobs are in there or has a latent bug for such cases.
Co-authored-by: Sudarsan Surendralal <surendralal@mpie.de>
sudarsan-surendralal
approved these changes
Feb 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute for #661 from @sudarsan-surendralal
This adds a local maintenance to the project, where one can trigger a rewrite_hdf for all jobs.