Move signal catching to separate module and refactor #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation also had the problem that it 1. never dropped the signal intercept, but installed it on first initialization of any job, even if the job then doesn't actually run, 2. didn't propagate the signal after it set the job to 'aborted', i.e. trying to interrupt notebooks when no job is running didn't actually interrupt the process 3. kept re-installing the same handler on every job instantiation. It's not that expensive, but it can cost a few percent of run time, depending on the size of the jobs. This new implementation only installs the handler during a functions `run()` method call with a context manager and raises KeyboardInterrupt or calls sys.exit as appropriate.
pmrv
commented
Jan 17, 2023
pmrv
added
the
integration
|
I've checked now on the cluster that this actually solves the problem of not being able anymore to interrupt notebooks after you've instantiated a job, so I'd like to merge this soon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation also had the problem that it
This new implementation only installs the handler during a functions
run()method call with a context manager and raises KeyboardInterrupt or calls sys.exit as appropriate.