Skip to content

Commit

Permalink
fix exp A
Browse files Browse the repository at this point in the history
  • Loading branch information
Leimeroth committed Feb 26, 2021
1 parent cd287b4 commit dbc138a
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions pyiron_contrib/atomistic/atomicrex/function_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,13 @@ def _to_xml_element(self, name):
for param in self.parameters.values():
p = ET.SubElement(root, f"{param.param}")
p.text = f"{param.start_val}"
root.append(self.parameters.fit_dofs_to_xml_element())

# This if condition is to prevent an error with the expA screening function
# It is a bit hacky and if another function with only 1 parameter is added
# it probably has to be rewritten
if len(self.parameters.values()) > 1:
root.append(self.parameters.fit_dofs_to_xml_element())

if not self.is_screening_function:
if self.screening is not None:
root.append(self.screening._to_xml_element())
Expand Down Expand Up @@ -354,7 +360,7 @@ def _to_xml_element(self):
p = ET.SubElement(root, "param")
p.set("name", f"{param.param}")
p.text = f"{param.start_val}"

root.append(self.parameters.fit_dofs_to_xml_element())

if not self.is_screening_function:
Expand Down Expand Up @@ -446,14 +452,13 @@ def add_parameter(self, param, start_val, enabled=True, reset=False, min_val=Non
def fit_dofs_to_xml_element(self):
"""Internal function
Returns fit dofs as atomicrex xml element.
"""
"""
fit_dof = ET.Element("fit-dof")
for param in self.values():
if param.fitable:
fit_dof.append(param._to_xml_element())
return fit_dof


class PolyCoeff(FunctionParameter):
"""
Function parameter, but for polynomial interpolation.
Expand Down

0 comments on commit dbc138a

Please sign in to comment.