Hotfix: Correct potential init for atomicrex #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still I guess we should discuss if it is possible to simplify the development of classes for pyiron - maybe on friday in the pyiron meeting. I guess @Leimeroth intention was to just derive from |
Yes I derived so much from InputList because I like how they look in jupyter and because I hoped to avoid manually messing with the hdf5 input/output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that even though
AbstractPotentialderives fromInputList, it doesn't act like one, because it doesn't accept a list initializer in its init.InputList.from_hdfdepends on that possibility though. I haven't tried it, but this should work.However the better fix would be that
AbstractPotentialdoesn't derive fromInputList(since it is not intended to be used like one) and instead has a private member that is anInputList. Then you can still use the list for HDF5 storage, but without breaking its protocol.