-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose root node #165
Expose root node #165
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Pull Request Test Coverage Report for Build 7576748024Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
We might have a storage root, etc. Also, the graph and the semantics are not identical, as multiple workflows might have a semantic (but not operational) interaction, so then we'd care about a semantic root! Plus it makes find-usages easier on the IDE when we have a more specific name.
Adds a new instance property
Node.root: -> Node
that returns the parent-most node in the node's graph. For the parent-most node or nodes all alone, theroot
is justself
.Access to this sort of graph property seems intrinsically nice to me, but in particular I have in mind to use it for specifying nodes as "checkpoints", i.e. points at which the graphs save themselves, by adding a
finally
clause toNode._finish_run
like:I included documentation at the docstring level, but since we don't yet have a use-case (e.g. above) I don't see a need to modify any notebooks or train users on this property.