Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Replace while with a macro pattern #364

Merged
merged 7 commits into from
Jun 12, 2024
Merged

[minor] Replace while with a macro pattern #364

merged 7 commits into from
Jun 12, 2024

Commits on Jun 12, 2024

  1. Add a new standard node for appending to a list

    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    de6eefa View commit details
    Browse the repository at this point in the history

  2. Demonstrate and test while loops as a macro 

    This is pickleable and clear to write and read. I don't have a convenience wrapper yet to get rid of the "universal" stuff though.
    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    eb9418f View commit details
    Browse the repository at this point in the history

  3. Remove the while-loop metanode 

    It was janky, the UI was not even particularly nice, and it wouldn't pickle. Just axe it.
    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    cd7dbb6 View commit details
    Browse the repository at this point in the history

  4. 🐛 include the new standard node in the exported nodes list

    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    dd17275 View commit details
    Browse the repository at this point in the history

  5. Improve test comments

    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    168c59f View commit details
    Browse the repository at this point in the history

  6. Update deepdive to use the new while example 

    Instead of the old while metanode
    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9a88467 View commit details
    Browse the repository at this point in the history

  7. Remove unused import

    @liamhuber
    liamhuber committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2a8fa88 View commit details
    Browse the repository at this point in the history