Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Better error messages #365

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[patch] Better error messages #365

merged 2 commits into from
Jun 18, 2024

Conversation

liamhuber
Copy link
Member

Adds a new property HasLabel.full_label; for HasLabel it's identical to label, but for Node it uses the semantic path, and for Channel it uses the owner's full_label plus the channel label.

In nodes it uses the semantic path, in channels it uses the owner's full label
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/better_messages

Copy link

codacy-production bot commented Jun 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 90.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7f48546) 3415 3158 92.47%
Head commit (3aff1ee) 3425 (+10) 3167 (+9) 92.47% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#365) 10 9 90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9555957012

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.007%) to 92.467%

Files with Coverage Reduction New Missed Lines %
mixin/has_interface_mixins.py 2 90.0%
mixin/semantics.py 3 96.86%
topology.py 4 88.46%
node.py 6 94.36%
workflow.py 6 80.87%
channels.py 12 94.32%
Totals Coverage Status
Change from base Build 9488612738: -0.007%
Covered Lines: 3167
Relevant Lines: 3425

💛 - Coveralls

@liamhuber liamhuber merged commit 05ebef7 into main Jun 18, 2024
18 checks passed
@liamhuber liamhuber deleted the better_messages branch June 18, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants