Check the existence of the remote file before transferring the file #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a comment as to why this stat call is needed, so that the next person doesn't think it's unnecessary code and removes it again. A short line summarizing the discussion in pyiron/pyiron#1526 will do. |
pmrv
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the remote file doesn't exist, the statement
sftp_client.get(file_dst, file_src)will raiseFileNotFoundError. The expected behavior is to skip. But theparamikosftp connection will make the local file to empty. Thus, addsftp_client.stat(file_dst)to check remote file existence. If the remote file is not exists, theFileNotFoundErrorwill raise before the the file transfer.