[DOC] Add MWE to 3 more functions #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1006--pyjanitor.netlify.app |
|
@thatlittleboy looks like we have one error that relates to syntax. Here is a direct link to the logs: https://github.com/pyjanitor-devs/pyjanitor/runs/5069210330?check_suite_focus=true#step:4:1617 |
samukweku
approved these changes
Feb 4, 2022
Codecov Report
@@ Coverage Diff @@
## dev #1006 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 77 77
Lines 2858 2858
=======================================
Hits 2753 2753
Misses 105 105 |
ericmjl
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
functions/row_to_names,functions/shuffle,functions/round_to_fraction.fill_empty.py(leftover from the previous migration)Resolves #1004 ; Related to #972 .
Aside:
Bugfix for issue 1005 (also relating to the
round_to_fraction.pyfile) will be in another PR, I wanted to keep this PR more focused on the MWE additions.I'll update the CHANGELOG for 1004 together with the fix for 1005 in that PR.