-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add minimum working examples to clean_names and case_when #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://deploy-preview-978--pyjanitor.netlify.app |
ericmjl
changed the title
[DOC] Add minimum working example for case_when
[DOC] Add minimum working examples
Jan 7, 2022
Codecov Report
@@ Coverage Diff @@
## dev #978 +/- ##
==========================================
+ Coverage 96.31% 96.34% +0.02%
==========================================
Files 77 77
Lines 2794 2816 +22
==========================================
+ Hits 2691 2713 +22
Misses 103 103 |
ericmjl
requested review from
hectormz,
loganthomas,
samukweku and
thatlittleboy
January 8, 2022 14:23
ericmjl
changed the title
[DOC] Add minimum working examples
[DOC] Add minimum working examples to clean_names and case_when
Jan 8, 2022
thatlittleboy
approved these changes
Jan 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just pointed a couple formatting issues to fix. The overall logic and "minimalism" of the examples LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minimum working examples to two functions,
clean_names
andcase_when
.Related to: #972.