Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add minimum working examples to clean_names and case_when #978

Merged
merged 7 commits into from
Jan 8, 2022

Conversation

ericmjl
Copy link
Member

@ericmjl ericmjl commented Jan 7, 2022

This PR adds minimum working examples to two functions, clean_names and case_when.

Related to: #972.

@ericmjl
Copy link
Member Author

ericmjl commented Jan 7, 2022

🚀 Deployed on https://deploy-preview-978--pyjanitor.netlify.app

@ericmjl ericmjl changed the title [DOC] Add minimum working example for case_when [DOC] Add minimum working examples Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #978 (437dbc3) into dev (9ecd6fe) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #978      +/-   ##
==========================================
+ Coverage   96.31%   96.34%   +0.02%     
==========================================
  Files          77       77              
  Lines        2794     2816      +22     
==========================================
+ Hits         2691     2713      +22     
  Misses        103      103              

@ericmjl ericmjl changed the title [DOC] Add minimum working examples [DOC] Add minimum working examples to clean_names and case_when Jan 8, 2022
Copy link
Contributor

@thatlittleboy thatlittleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just pointed a couple formatting issues to fix. The overall logic and "minimalism" of the examples LGTM :)

janitor/functions/case_when.py Outdated Show resolved Hide resolved
janitor/functions/case_when.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants