-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add tidyxl's xlsx_table
to the io
module.
#990
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #990 +/- ##
==========================================
+ Coverage 96.28% 96.32% +0.04%
==========================================
Files 77 77
Lines 2826 2859 +33
==========================================
+ Hits 2721 2754 +33
Misses 105 105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, @samukweku! I put in some early review comments here. There are tests that are missing too, but I trust you're already working on them. Looking forward to reviewing!
I'm inclined to ignore the decrease in project test coverage; they're irrelevant to the PR. 100% of the patch diff being hit is good enough. |
Btw, @samukweku, I think going forth you can use a branch off the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the tests provided here, @samukweku, they're really comprehensive!
I have only a few nit-picky requests for changes. They are explicit requests for changes, rather than mere suggestions, because I think changing them will help with maintenance clarity. Hope you don't mind them!
xlsx_table
to the io
module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, immediately thought of another point I would like to make in the review right as I pressed "Submit" 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving. I looked on CodeCov and saw that the missed patch is on the conditional import. I don't think it's easy to test that in the current testing environment, so we should let it go.
I'm going to approve! @thatlittleboy since you also did a big review on this one, feel free to approve and merge!
@samukweku There's a merge conflict in |
PR Description
Please describe the changes proposed in the pull request:
This PR resolves #992 .
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.