Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some French jokes #91

Merged
merged 5 commits into from May 30, 2023
Merged

Add some French jokes #91

merged 5 commits into from May 30, 2023

Conversation

alfreddagenais
Copy link
Contributor

My contribution of french jokes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 85.965% when pulling 14a015d on alfreddagenais:french into 05dbf7e on pyjokes:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 85.965% when pulling 14a015d on alfreddagenais:french into 05dbf7e on pyjokes:master.

@alfreddagenais alfreddagenais mentioned this pull request Nov 9, 2020
@alexsavio
Copy link
Member

LGTM! I think we should merge! Thank you!

@apennamen
Copy link

Hello,
Mycroft.ai joke skill rely on this project to tell jokes. As there are still no french jokes added (at least a first round), it fails...
Could we at least merge this work from alfreddagenais ?
Regards,
AP

@vpoulailleau
Copy link
Contributor

Hi, thanks for this contribution, we're missing french jokes. Just one remark though, in french there is a mandatory non-breakable space before every !?:;

Some of them are missing.

@alfreddagenais
Copy link
Contributor Author

@vpoulailleau Il follow somes rules from https://www.btb.termiumplus.gc.ca/redac-chap?lang=fra&lettr=chapsect6&info0=6.13 https://vitrinelinguistique.oqlf.gouv.qc.ca/index.php?id=22039

For me seem not required, but I think i am confused with some rules 🤔 What do you think about this rules? Or have you other link to give me indications

Thank you 😃

@vpoulailleau
Copy link
Contributor

@alfreddagenais I don't know the Canadian rules you provided, maybe they are different. I was suggesting the French ones that are explained here for instance:

@alexsavio alexsavio merged commit 8d04740 into pyjokes:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants