Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogBox move broken on IE #125

Open
pyjsorg opened this issue Apr 27, 2012 · 2 comments
Open

DialogBox move broken on IE #125

pyjsorg opened this issue Apr 27, 2012 · 2 comments
Labels

Comments

@pyjsorg
Copy link
Contributor

pyjsorg commented Apr 27, 2012

KitchenSink - Popups - Show Dialog

Cannot move dialog around

0304c30 is first bad commit
Adds GlassWidget browser-specific override to fix issue 498
new file: library/ie6/pyjamas/ui/GlassWidget.py

Original issue: http://code.google.com/p/pyjamas/issues/detail?id=598 (April 26, 2011 15:13:03)

@pyjsorg
Copy link
Contributor Author

pyjsorg commented Apr 27, 2012

From cornelis...@gmail.com on April 26, 2011 15:22:51:
Added a minimal example app to this issue.

@pyjsorg
Copy link
Contributor Author

pyjsorg commented Apr 27, 2012

From rich.new...@gmail.com on April 26, 2011 22:54:56:
OK I have the fix - I tested the example app on Windows with the following:

  • pyjd
  • IE 9
  • FF 4
  • Safari
  • Opera
  • Chrome

and all seems fine. There were two problems:

  1. The DialogBox.py file was incorrectly using 'self' as the widget to trap events through GlassWidget. Actually, the mouse handler of the DialogBox is the caption and that is the widget to be passed. Also, since MouseHandler does not define the glass events, python exceptions would occur under pyjd, so the glass enter/leave placeholder methods were added to Mousehandler.
  2. The previewEvent method in PopupPanel.py was relying on DOM to tell it whether a mouse capture was in progress. The GlassWidget IE override did not involve DOM in the capture/release. That has been fixed by allowing browser-specific implementations to set/release capture, then letting GlassWidget simply use DOM to set/release capture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant