Test video domain adapter #145
Conversation
xianyuanliu
added
work-in-progress
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
===========================================
+ Coverage 73.18% 84.08% +10.90%
===========================================
Files 44 44
Lines 4098 4122 +24
===========================================
+ Hits 2999 3466 +467
+ Misses 1099 656 -443
Continue to review full report at Codecov.
|
xianyuanliu
removed
the
work-in-progress
tests/loaddata/test_digits_access.py
Outdated
| @@ -19,6 +21,7 @@ | |||
| @pytest.mark.parametrize("source_name", SOURCES) | |||
| @pytest.mark.parametrize("target_name", TARGETS) | |||
| def test_get_source_target(source_name, target_name, download_path): | |||
| download_path = os.path.join(os.path.dirname(os.path.dirname(os.getcwd())), download_path) | |||
There was a problem hiding this comment.
Why not change download_path in conftest.py this way (of absolute path) instead? You've repeated it three times. Whenever there are many such repetition, think of reduction.
There was a problem hiding this comment.
I changed but some issues raised. I don't know if others use this, so I only change this file. I will try again to change the conftest.py
There was a problem hiding this comment.
Why do you make this change in the first place? It works well earlier and you did not change anything relevant to this module.
tests/helpers/boring_model.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| # Models for efficient test. | |||
There was a problem hiding this comment.
I recall you learn this from somewhere. Add a reference?
| @@ -625,39 +659,24 @@ def critic_update_steps(self, batch): | |||
| h_s = torch.cat((h_s_rgb, h_s_flow), dim=1) | |||
| h_t = torch.cat((h_t_rgb, h_t_flow), dim=1) | |||
|
|
|||
| # Need to improve to process rgb and flow dividedly in the future. | |||
There was a problem hiding this comment.
individually or separately, not dividedly
| seed = 36 | ||
| set_seed(seed) | ||
|
|
||
| root_dir = os.path.dirname(os.path.dirname(os.getcwd())) |
There was a problem hiding this comment.
Think again, whether this is necessary. If yes, it may be needed in others tests so consider putting in conftest.py.
…ss.py" This reverts commit 12b86af.
Description
Status
Ready
Types of changes
docsmanually updated for new API.