Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concord_index calculation into DeepDTA #157

Merged
merged 2 commits into from Jun 15, 2021
Merged

Add concord_index calculation into DeepDTA #157

merged 2 commits into from Jun 15, 2021

Conversation

peizhenbai
Copy link
Collaborator

Description

  • Add CI calculation into deep_dti pipeline
  • Add CI metric test case (test_deep_dti)
  • Rename c_index to concord_index
  • Add default lr value

Status

*Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • In-line docstrings updated.

@peizhenbai peizhenbai added enhancement Improvement of existing code tests Tests and coverage labels Jun 15, 2021
@github-actions github-actions bot added this to In progress in v0.1.0 Jun 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #157 (8de2004) into main (6eb6e56) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   88.08%   88.36%   +0.27%     
==========================================
  Files          44       44              
  Lines        4156     4167      +11     
==========================================
+ Hits         3661     3682      +21     
+ Misses        495      485      -10     
Impacted Files Coverage Δ
kale/evaluate/metrics.py 91.66% <100.00%> (+91.66%) ⬆️
kale/pipeline/deep_dti.py 90.00% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb6e56...8de2004. Read the comment docs.

@haipinglu haipinglu enabled auto-merge June 15, 2021 06:45
@haipinglu haipinglu merged commit 19a51c9 into main Jun 15, 2021
@haipinglu haipinglu deleted the test_ci branch June 15, 2021 06:47
v0.1.0 automation moved this from In progress to Done Jun 15, 2021
@github-actions github-actions bot mentioned this pull request Jun 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing code tests Tests and coverage
Projects
No open projects
v0.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants