Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe use of YAML #212

Merged
merged 7 commits into from Sep 8, 2021
Merged

Describe use of YAML #212

merged 7 commits into from Sep 8, 2021

Conversation

bobturneruk
Copy link
Collaborator

Fixes #163.

Description

Adds a brief description of how YAML allows users to declaratively specify models.

Status

Work in progress

On the right (delete these after selection):

  • Select a reviewer if ready for review. Use the suggested one if unsure.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@bobturneruk bobturneruk added documentation Improvements or additions to documentation work-in-progress Work in progress that should NOT be merged labels Sep 6, 2021
@github-actions github-actions bot added this to In progress in v0.1.0 Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #212 (de09280) into main (0ec2513) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          49       49           
  Lines        4737     4737           
=======================================
  Hits         4260     4260           
  Misses        477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec2513...de09280. Read the comment docs.

@haipinglu
Copy link
Member

haipinglu commented Sep 8, 2021

@bobturneruk I'll give a virtual talk on PyKale next Tuesday so hope to have this merged this week for another release. Thanks.

@bobturneruk
Copy link
Collaborator Author

Hopefully this is a reasonable technical description of how PyKale uses YAML.

Perhaps a snazzy static website e.g. https://monai.io/, https://github.com/Project-MONAI/project-monai.github.io to really "sell" this feature (and others) would be a nice future development if we can get the design skills in the team. If so, a separate discussion / issue would be appropriate.

@haipinglu
Copy link
Member

Hopefully this is a reasonable technical description of how PyKale uses YAML.

Perhaps a snazzy static website e.g. https://monai.io/, https://github.com/Project-MONAI/project-monai.github.io to really "sell" this feature (and others) would be a nice future development if we can get the design skills in the team. If so, a separate discussion / issue would be appropriate.

Maybe part of the proposal.

@haipinglu haipinglu merged commit 411a6f0 into main Sep 8, 2021
v0.1.0 automation moved this from In progress to Done Sep 8, 2021
@haipinglu haipinglu deleted the yaml branch September 8, 2021 16:52
@github-actions github-actions bot mentioned this pull request Sep 10, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation work-in-progress Work in progress that should NOT be merged
Projects
No open projects
v0.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

Docs on YAML
4 participants