New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo and hyperlink #235
Conversation
@bobturneruk We should apply a quick fix to the problem first. Otherwise, we cannot do any merge before it gets fixed due to failed test. Possible for you to do it (in this PR or a separate small PR). How to reporting the error should be a separate issue to deal with. |
@haipinglu - "the first problem" is #230? |
Yes, the certifi update caused the tests to fail: https://github.com/pykale/pykale/pull/235/checks?check_run_id=3879026540 |
I'll have a look at this when I get time - hopefully this week. If anyone else have more time then I'd encourge them to work on #230. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done Valentin! So pleased to see that you will become a contributor listed on PyKale in one hour or so!
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 45 45
Lines 4587 4587
=======================================
Hits 4236 4236
Misses 351 351 Continue to review full report at Codecov.
|
Fixes #234. Fixes #231.
Description
On the main page there was a broken hyperlink for [ branch, fork, and pull] and now it has been fixed.
On the pykale/examples/cmri_mpca/ the running description had a small typo and now it has been fixed.
Status
Ready
On the right (delete these after selection):
Types of changes