Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo and hyperlink #235

Merged
merged 3 commits into from Oct 13, 2021
Merged

Fixed typo and hyperlink #235

merged 3 commits into from Oct 13, 2021

Conversation

19valentin99
Copy link
Collaborator

@19valentin99 19valentin99 commented Oct 12, 2021

Fixes #234. Fixes #231.

Description

On the main page there was a broken hyperlink for [ branch, fork, and pull] and now it has been fixed.
On the pykale/examples/cmri_mpca/ the running description had a small typo and now it has been fixed.

Status

Ready

On the right (delete these after selection):

  • Select a reviewer if ready for review. Use the suggested one if unsure.
  • Select at least one appropriate label.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@19valentin99 19valentin99 changed the title Fixed typo and hyperlink :documentation Fixed typo and hyperlink Oct 12, 2021
@19valentin99 19valentin99 changed the title :documentation Fixed typo and hyperlink Fixed typo and hyperlink Oct 12, 2021
@haipinglu
Copy link
Member

Thanks. You should specify the issues that this PR fixes. See my edit at the top: "Fixes #234. Fixes #231" so that they will be closed automatically when merged.

@haipinglu
Copy link
Member

@bobturneruk We should apply a quick fix to the problem first. Otherwise, we cannot do any merge before it gets fixed due to failed test. Possible for you to do it (in this PR or a separate small PR).

How to reporting the error should be a separate issue to deal with.

@bobturneruk
Copy link
Collaborator

@haipinglu - "the first problem" is #230?

@haipinglu
Copy link
Member

@haipinglu - "the first problem" is #230?

Yes, the certifi update caused the tests to fail: https://github.com/pykale/pykale/pull/235/checks?check_run_id=3879026540

@bobturneruk
Copy link
Collaborator

I'll have a look at this when I get time - hopefully this week. If anyone else have more time then I'd encourge them to work on #230.

Copy link
Member

@haipinglu haipinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Valentin! So pleased to see that you will become a contributor listed on PyKale in one hour or so!

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #235 (7f5ccd9) into main (bd4de88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          45       45           
  Lines        4587     4587           
=======================================
  Hits         4236     4236           
  Misses        351      351           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4de88...7f5ccd9. Read the comment docs.

@haipinglu haipinglu merged commit 664cafe into pykale:main Oct 13, 2021
@github-actions github-actions bot mentioned this pull request Oct 13, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] 404-not found hyperlink on main page [Bug] Typo in running the cmri_mpca from terminal
4 participants