Skip to content

Commit

Permalink
馃惡 馃┕ Fix tensorboard tracker (#476)
Browse files Browse the repository at this point in the history
  • Loading branch information
cthoyt committed Jun 2, 2021
1 parent 811fa2b commit 9b7adc6
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/pykeen/trackers/tensorboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import pathlib
import time
from typing import Any, Dict, Mapping, Optional, TYPE_CHECKING, Union
from typing import Any, Mapping, Optional, TYPE_CHECKING, Union

from .base import ResultTracker
from ..constants import PYKEEN_LOGS
Expand Down
10 changes: 9 additions & 1 deletion tests/test_trackers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,18 @@

"""Tests for result trackers."""

import unittest

from pykeen.trackers import TensorBoardResultTracker
from pykeen.trackers.base import ConsoleResultTracker
from pykeen.trackers.file import CSVResultTracker, JSONResultTracker
from tests import cases

try:
import tensorboard
except ImportError:
tensorboard = None


class CSVResultTrackerTests(cases.FileResultTrackerTests):
"""Tests for CSVResultTracker."""
Expand All @@ -26,7 +33,8 @@ class ConsoleResultTrackerTests(cases.ResultTrackerTests):
cls = ConsoleResultTracker


@unittest.skipIf(tensorboard is None, reason='TensorBoard is not installed')
class TensorboardTrackerTests(cases.ResultTrackerTests):
"""Tests for console tracker."""
"""Tests for TensorBoard tracker."""

cls = TensorBoardResultTracker
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ passenv =
HOME
extras =
mlflow
tensorboard
tests
whitelist_externals =
/bin/cat
Expand Down

0 comments on commit 9b7adc6

Please sign in to comment.