Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproducible experiments #432

Closed
lzw950905 opened this issue May 9, 2021 · 3 comments
Closed

reproducible experiments #432

lzw950905 opened this issue May 9, 2021 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@lzw950905
Copy link

Describe the bug
I want to use the experiment setting published in ''Bringing Light Into the Dark: A Large-scale Evaluation of Knowledge Graph Embedding Models Under a Unified Framework.''. One setting is "training_loop": "OWA". But when I run, it shows that ''ValueError: Invalid TrainingLoop name: OWA. Valid choices are: ['lcwa', 'slcwa']''.

To Reproduce
Steps to reproduce the behavior:

  1. Use the pipeline and correponding para setting.
  2. Run the code

Expected behavior
Run normally and could get the performance like you did after experiments.

@lzw950905 lzw950905 added the bug Something isn't working label May 9, 2021
@mali-git
Copy link
Member

mali-git commented May 9, 2021

Hi @lzw950905,
We have updated the nomenclature in the subsequent versions. owa has been renamed to slcwa (stochastic local closed world assumption).

@mali-git mali-git added invalid This doesn't seem right and removed bug Something isn't working labels May 9, 2021
@cthoyt
Copy link
Member

cthoyt commented May 9, 2021

@mali-git shouldn’t we update the config files to reflect the new name?

@mali-git
Copy link
Member

mali-git commented May 10, 2021

@mali-git shouldn’t we update the config files to reflect the new name?

Maybe we can add a conversion script (in the benchmarking repository)? This would ensure that the configurations can be executed with the version used for the experiments and ensures that the configurations can be used with the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants