Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尓馃樋Fix epoch loss #1021

Merged
merged 3 commits into from
Jul 7, 2022
Merged

馃尓馃樋Fix epoch loss #1021

merged 3 commits into from
Jul 7, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Jul 4, 2022

Fix #1020

@cthoyt
Copy link
Member

cthoyt commented Jul 4, 2022

Should we be handling the reduction type anywhere else?

@mberr
Copy link
Member Author

mberr commented Jul 4, 2022

There is already some handling inside the loss functions, e.g., here

pykeen/src/pykeen/losses.py

Lines 839 to 840 in b0a9abd

if self.reduction == "sum":
positive_loss = positive_loss * negative_scores.shape[1]

I am not aware of any other location where we should need to look at the reduction, and don't do it yet.

@cthoyt
Copy link
Member

cthoyt commented Jul 6, 2022

Needs emoji

@cthoyt cthoyt changed the title Fix epoch loss 馃尓馃樋Fix epoch loss Jul 7, 2022
@cthoyt cthoyt marked this pull request as ready for review July 7, 2022 02:16
@cthoyt cthoyt enabled auto-merge (squash) July 7, 2022 02:16
@cthoyt cthoyt merged commit 091c10f into master Jul 7, 2022
@cthoyt cthoyt deleted the fix-epoch-loss branch July 7, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue in loss scaling
2 participants