Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃┕馃挴 Fix typo in OpenEA graph size #1073

Merged
merged 1 commit into from
Aug 15, 2022
Merged

馃┕馃挴 Fix typo in OpenEA graph size #1073

merged 1 commit into from
Aug 15, 2022

Conversation

dobraczka
Copy link
Contributor

Fixes wrong size of 100K version of OpenEA dataset

Contributing to bug fixes

  • Fill out the template below
  • The pull request should only fix existing bug reports
  • The pull request should comply with these points mentioned in the contribution guidelines

Link to the relevant Bug(s)

OpenEA dataset graph size variable SIZE_100K is set to "15K"

Description of the Change

Change the string to "100K"

Possible Drawbacks

None

Verification Process

I changed the variable and checked that OpenEA(size="100K") can be run (which was previously not possible)

Release Notes

  • Fixed graph size bug in OpenEA dataset

Fixes wrong size of 100K version of OpenEA dataset
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update any documentation? or is the 15K the one that's represented by default in the docs

@dobraczka
Copy link
Contributor Author

No, the 15K was the default in the docs

@cthoyt
Copy link
Member

cthoyt commented Aug 15, 2022

@dobraczka please pick 2 emoji for this PR then we can merge

@dobraczka dobraczka changed the title Fix typo in OpenEA graph size 馃┕馃挴 Fix typo in OpenEA graph size Aug 15, 2022
@cthoyt cthoyt self-requested a review August 15, 2022 14:18
@cthoyt cthoyt enabled auto-merge (squash) August 15, 2022 14:18
@cthoyt cthoyt merged commit a8ffada into pykeen:master Aug 15, 2022
@dobraczka dobraczka deleted the patch-1 branch August 15, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants