🔍📈 Fix MacroRankBasedEvaluator share precomputed weights for different triples #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use defaultdict in __init__ for weights so that weights can be reassigned after finalize is called move hrt_batch to cpu in process_scores
mberr
changed the title
|
@Allaway11 can you take a look at this? |
mberr
changed the title
cthoyt
reviewed
Aug 18, 2022
cthoyt
reviewed
Aug 18, 2022
Looks good to me! 🚀 👍 |
|
don't merge yet; I found a few occasions where we can re-use the constant 🙂 |
|
Fine, merge when ready |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pre-calculation of macro weights, and do this during finalization (of one evaluation round) instead. This should fix the problem with validation weights overlapping with test weights.
Dependencies