🔮☕ Custom Prediction Filtering #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Aug 25, 2022
cthoyt
reviewed
Aug 25, 2022
cthoyt
reviewed
Aug 26, 2022
| @@ -203,7 +203,7 @@ def predict_hrt_uncertain( | |||
| Example Usage:: | |||
|
|
|||
| from pykeen.pipeline import pipeline | |||
| from pykeen.models.predict import predict_hrt_uncertain | |||
| from pykeen.models.uncertainty import predict_hrt_uncertain | |||
There was a problem hiding this comment.
does this module now rely on pykeen.predict? sort of complicated, maybe this module should also be in a predict subpackage?
There was a problem hiding this comment.
I am unsure about this 😅
The uncertainty module only wraps the model's predict_{h,r,t}, but does not offer the flexibility of the general predict module.
|
I'm still hesitant about throwing away the nice high-level functions but I don't want to get in the way since you're on a roll |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the prediction filtering (again) to better support custom filtering.
Dependencies