↔️⭐ Merge ComplEx interaction #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
cthoyt
reviewed
Nov 20, 2022
| @@ -30,6 +30,7 @@ class ComplExTests(cases.InteractionTestCase): | |||
| cls = pykeen.nn.modules.ComplExInteraction | |||
| dtype = torch.cfloat | |||
|
|
|||
| # TODO: we could move this part into the interaction module itself | |||
There was a problem hiding this comment.
I think that might be helpful eventually so code is more centralized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges ComplEx' functional interaction with the (functional) module. It also de-duplicates information between the ComplEx model class and the interaction, and updates the docstring.
It is also intended to serve as an example on how to do #1102 .