馃悰馃悢 Fixing bug with index-error for predict.consume_scores #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed indexError where it had flipped the the remainder and quotient. (Error not visible on original code snippet as it had the same amount of entities and relation (making it a square). If say we had 1000 entities and 1 relation (1000 x 1) it would orginially iterate (1 x 1000) getting an index error. This flips these indices.
|
Hi @AImenes , thanks for your pr! I added a small test case swhich would have discovered the previous error. |
3 tasks
cthoyt
approved these changes
Nov 7, 2022
cthoyt
approved these changes
Nov 19, 2022
|
pipeline failures -> #1170 |
mberr
changed the title
|
Thanks for being patient @AImenes! We made a few minor updates and merged it. |
|
Thank you! 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the relevant Bug(s)
fix #1156
Description of the Change
Remainder is actually quotient, and quotient is actually remainder. The Change flips these.
Fixed
IndexErrorwhere it had flipped the the remainder and quotient. (Error not visible on original code snippet as it had the same amount of entities and relation (making it a square). If say we had 1000 entities and 1 relation (1000 x 1) it would originally iterate (1 x 1000) getting an index error. This flips these indices.My guess is this error occurred when the working example had same amount of entities and relations, so it would work regardless just iterating horizontally instead of vertically.
Possible Drawbacks
__getitem__(line 876-878), it will also flip for them.Verification Process
Release Notes