Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 🛠️ Fix losses docs typos #1200

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Conversation

nicolafan
Copy link
Contributor

Fix #1199

Fix typos in the documentation of different loss functions.

The typos mostly concern the inversion of the symbols for negative and positive examples in the definition of the losses and the specification of the TransE interaction function.

As a verification process, the docs were rebuilt and checked manually via tox -e docs.

@mberr mberr requested review from cthoyt and mberr and removed request for cthoyt January 14, 2023 09:02
@mberr mberr enabled auto-merge (squash) January 14, 2023 11:14
@mberr mberr disabled auto-merge January 14, 2023 11:21
@mberr mberr enabled auto-merge (squash) January 14, 2023 11:29
@mberr mberr merged commit 9bf4c5d into pykeen:master Jan 14, 2023
@cthoyt
Copy link
Member

cthoyt commented Jan 14, 2023

Thanks, @nicolafan !

@nicolafan
Copy link
Contributor Author

You're welcome!😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Losses documentation typos
3 participants